Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#304 팀페이지 권한 수정 #306

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

llddang
Copy link
Collaborator

@llddang llddang commented Sep 22, 2024

관련 이슈

작업 요약

  • 팀페이지 권한 작업 수정

작업 상세 설명

  • 기존의 팀원한테도 UI가 안보이는 이슈는 myTeamAtom에 내용을 저장하고 있지 않아서 입니다.
  • 사이드바에서 나의 팀 정보를 불러올 때, 해당 정보를 저장해주어서 해결했습니다.

리뷰 요구 사항

  • 리뷰 예상 시간: 3분

@llddang llddang added 🐞 버그 예기치 못한 동작 발생 🎨 디자인 CSS 등 사용자 UI 디자인 변경 labels Sep 22, 2024
@llddang llddang self-assigned this Sep 22, 2024
Comment on lines 26 to 32
useEffect(() => {
const myTeams = sidebarInfo
? sidebarInfo.body.myTeamsAndStudies.map((team: { teamId: number }) => team.teamId)
: [];
setMyTeams(myTeams);
}, [setMyTeams, sidebarInfo]);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
비회원일 때 이런 오류가 뜨던데 혹시 땅님은 괜찮으시던가요?

const myTeams = sidebarInfo?.body.myTeamsAndStudies
      ? sidebarInfo.body.myTeamsAndStudies.map((team: { teamId: number }) => team.teamId)
      : [];

저는 이렇게 바꿔줘야 오류가 안 뜨더라구요..!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다!

Copy link
Collaborator

@jasper200207 jasper200207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@yeonddori yeonddori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shaun

Copy link
Collaborator

@mun-kyeong mun-kyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

@llddang llddang merged commit 3f8c00c into develop Sep 27, 2024
1 check passed
@llddang llddang deleted the Feature/#304-팀페이지_권한_수정 branch September 27, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 디자인 CSS 등 사용자 UI 디자인 변경 🐞 버그 예기치 못한 동작 발생
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 팀 페이지에서 권한에 따른 특정 UI가 안 보이는 이슈 해결
4 participants