-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#305 스터디페이지 권한 수정 #307
The head ref may contain hidden characters: "Feature/#305-\uC2A4\uD130\uB514\uD398\uC774\uC9C0_\uAD8C\uD55C_\uC791\uC5C5"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
옹 그렇네요 이것도 반영해놓을 게요! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
코멘트는 큰 문제는 없을 듯 해서 Approve 하겠습니다
deleteModalOpen={setIsDeleteModalOpen} | ||
/> | ||
<Grid gap="4" templateColumns={{ base: '', xl: '2fr 1fr' }} w="100%"> | ||
{user?.memberId === studyData?.studyLeaderId && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분 user가 null 이고 studyData도 null 이라면 True로 판단될 수 있을 듯 합니다.
studyData && user?.memberId === studyData.studyLeaderId &&
로 고치는 것도 좋아보입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다~! 저도 비회원일때로 확인되더라구요 수고하셨습니다
…into Feature/#305-스터디페이지_권한_작업
관련 이슈
작업 요약
리뷰 요구 사항
1분