Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#302 커리큘럼 관련 api 수정 #316

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

mun-kyeong
Copy link
Collaborator

관련 이슈

작업 요약

  • 커리큘럼 수정 삭제 생성 입니다

작업 상세 설명

  • 백엔드측에서 순서 정렬하는거 수정되었다고 연락받아서 pr 올립니다!
  • 커리큘럼 수정 삭제 생성 가능합니다

리뷰 요구 사항

  • 없습니다

미리 보기

image
스크린샷 2024-09-22 오후 8 06 03
스크린샷 2024-09-22 오후 8 06 16
스크린샷 2024-09-22 오후 8 06 40

@mun-kyeong mun-kyeong added the ✨ 기능 개발 새로운 기능을 구현하는 데 필요한 작업 또는 변경 사항 label Sep 22, 2024
@mun-kyeong mun-kyeong self-assigned this Sep 22, 2024
Copy link
Collaborator

@llddang llddang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원래 맡았던 파트가 아니라 코드 이해부터 해야해서 힘들었을 것 같은데 수고많았습니다!!


const editCurriculumRef = React.useRef<HTMLTextAreaElement>();
// const getCurriculumItems = useGetFetchWithToken(getCurriculum, [Number(studyId)]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석은 삭제해주세요~!

@@ -24,8 +24,10 @@ const CurriculumModal = ({ isOpen, onClose, originCurriculums }: CurriculumModal

const [newCurriculum, setNewCurriculum] = useState<string>('');
const [newCurriculumId, setNewCurriculumId] = useState<number>(1);
const [firstNewCurriculumId, setFirstNewCurriculumId] = useState<number>(1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

밑의 139번째 줄을 보니 새로운 기본 값이 0인 것 같습니다.

setFirstNewCurriculumId(originCurriculums?.at(-1)?.id ?? 0);

firstNewCurriculumI의 초기값도 1보다는 0인 것이 좋아보입니다!

Copy link
Collaborator

@yeonddori yeonddori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shaun

@mun-kyeong mun-kyeong merged commit 5684b1a into develop Sep 27, 2024
1 check passed
@mun-kyeong mun-kyeong deleted the feature/#302_커리큘럼-관련-api-수정 branch September 27, 2024 12:32
@mun-kyeong mun-kyeong restored the feature/#302_커리큘럼-관련-api-수정 branch September 27, 2024 12:32
@mun-kyeong mun-kyeong deleted the feature/#302_커리큘럼-관련-api-수정 branch September 27, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 기능 개발 새로운 기능을 구현하는 데 필요한 작업 또는 변경 사항
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] 커리큘럼 관련 api 수정
3 participants