chore(deps-dev): remove Lit dependency #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The component should not be required to be a Lit element
barronhagerman
requested review from
ChadKillingsworth,
jrobinson01,
jivewise and
chrisgubbels
as code owners
|
This is probably fine but we'll need to test with a downstream typescript project to make sure things don't fall apart. Getting the types right on these mixins so they play nice with js, closure-compiler js, and ts has been a bear. |
jrobinson01
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
litdependency is only used for the TypeScript mixins. However, the constructor should not be required to be a Lit element, as it should work with any web component.litdependencyLitElementtype withHTMLElement