Fix strip on wearable #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wearable like `tf_wearable_demo_shield` cannot stripped by current method. - So set `m_bOnlyIterateItemViewAttributes` to true instead. There won't be any problem using this method for wearables.
Batfoxkid
requested changes
Nov 26, 2023
| { | ||
| char classname[36]; | ||
| GetEntityClassname(entity, classname, sizeof(classname)); | ||
| if(!StrContains(classname, "tf_wearable")) |
There was a problem hiding this comment.
I recommend checking against tf_weapon instead (because tf_powerup_bottle exists)
There was a problem hiding this comment.
I forgot that. I changed checking.
Batfoxkid
requested changes
Nov 27, 2023
| { | ||
| char classname[36]; | ||
| GetEntityClassname(entity, classname, sizeof(classname)); | ||
| if(StrContains(classname, "tf_weapon")) |
There was a problem hiding this comment.
This will cause it do the reserve as StrContains returns -1 with no matches and returns 0 when the string starts with the match.
There was a problem hiding this comment.
I'm sorry. I fixed it.
Batfoxkid
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf_wearable_demo_shieldcannot stripped by current method.m_bOnlyIterateItemViewAttributesto true instead. There won't be any problem using this method for wearable.Using ff2r's strip option(Attributes mean
dmg taken from fire reducedanddmg taken from blast reduced)Using cwx's
keep_static_attrs(strip) option(It usem_bOnlyIterateItemViewAttributes)