feat: add LocationPicker for students to select physical location #157
+475
−830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nspired by Issue #23.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // Map of location IDs to their configuration | ||
| // Each location can have different floor plans for staff/students | ||
| // Important: make sure the location ID value is for the correct room based on the database | ||
| const locationConfigs: Record<number, LocationConfig> = { |
There was a problem hiding this comment.
I worry if other classes use this, this might mess them up
perhaps what we can do is check if the name of the location is "Soda 271" or "Soda 273" also
There was a problem hiding this comment.
added checking of location name to next commit
…ches in addition to the location id.
kanavmittal314
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add LocationPicker for students to select physical location (inspired by issue #23), bump package versions.