Skip to content

Commit

Permalink
Fix for tinygo-org#4678: top-level 'make lint' wasn't working
Browse files Browse the repository at this point in the history
The revive command seems to have had a syntax error in the file
input glob. It appears to have been broken in a way that did not
result in a return code being set. This change uses 'find' to
build the input to the linter.

Note that it is expected to fail the CI script, because it is
uncovering some existing lint issues that were not being caught.
  • Loading branch information
cibomahto committed Jan 2, 2025
1 parent 0426a5f commit d2663fd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -1000,14 +1000,18 @@ endif
tools:
cd internal/tools && go generate -tags tools ./

LINTFILESCMD=find src/os/ src/reflect/ -type f -name '*.go'
.PHONY: lint
lint: tools ## Lint source tree
revive -version
# TODO: lint more directories!
# revive.toml isn't flexible enough to filter out just one kind of error from a checker, so do it with grep here.
# Can't use grep with friendly formatter. Plain output isn't too bad, though.
# Use 'grep .' to get rid of stray blank line
revive -config revive.toml compiler/... src/{os,reflect}/*.go | grep -v "should have comment or be unexported" | grep '.' | awk '{print}; END {exit NR>0}'
revive -config revive.toml compiler/... $$( $(LINTFILESCMD) ) \
| grep -v "should have comment or be unexported" \
| grep '.' \
| awk '{print}; END {exit NR>0}'

SPELLDIRSCMD=find . -depth 1 -type d | egrep -wv '.git|lib|llvm|src'; find src -depth 1 | egrep -wv 'device|internal|net|vendor'; find src/internal -depth 1 -type d | egrep -wv src/internal/wasi
.PHONY: spell
Expand Down

0 comments on commit d2663fd

Please sign in to comment.