Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and documentation #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renaudpawlak
Copy link

With this PR, we get a first version that works connecting to the prod API.
Plus, minimal documentation for anyone to get started.

@da-ekchajzer
Copy link
Contributor

Thank you very much for your PR. This is a very nice first version !

We can validate this PR.

Here are some remarks. Each point could lead to its own issue.

General

  • The open fields are hard to complete for users. The next version of the API will provide some utils routes with a list of accepted inputs. Thus, it will be possible to implement drop down menu instead of open fields.

README

Server description

  • Archetype : could be a drop-down menu. get_all_archetype_name router can be used to retrieve the available option
  • manufacturer and name won't be used. Maybe we could have a way to show the user that those field will not be used.

CPU

  • CPU family is an essential field. If not given the default value will be used. You can find the list of available families in the API repo.

RAM

  • Ram manufacturer is an essential field. If not given the default value will be used. You can find the list of available manufacturer in the API repo.

DISK

  • Type have only two options : SSD or HDD. A drop-down menu could replace the open field.
  • If disk's type is SSD : manufacturer is an essential field. If not given the default value will be used. You can find the list of available manufacturer

Power_supply

  • Units field doesn't show the selected quantity

Usage

Usage impacts cannot be configured. Thus, evaluated impacts don't make much sense.

Here is a query with the interesting elements to implement

{
"usage":{
  "hours_use_time": 1,      
  "days_use_time": 1,
  "years_use_time":  1,
  "usage_location": "FRA",
  "hours_electrical_consumption": 3
}
}

I hope these elements can help. I am now watching this repo. I'll answer faster to the open issues and PR. Do not hesitate to tag me if you need additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants