-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): migrate to node test runner #717
base: master
Are you sure you want to change the base?
Conversation
Interesting changes @minht11 I still have a few challenges, and they may be not be directly related to these change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You even migrated some decencies from Buffer
to UInt8Array
Do you mind to rebase this PR @minht11 ? |
b484469
to
00bd26e
Compare
Rebased it. {
"nodejs-testing.extensions": [
{
"extensions": ["mts", "cts", "ts"],
"parameters": ["--import", "tsx"]
}
]
} You should look into if there some way to pass arguments inside IntellijJ as well. |
I am sorry @minht11 , I need to ask you to rebase again. You have made good changes to the unit tests, which already applied on the default branch, so I hope it is not so painful this time. I can also rebase if you prefer. |
00bd26e
to
1fedce0
Compare
No problem. Rebased it. |
You can exclude Node.js version 16 from the Matrix, to pass all the unit tests:
|
1fedce0
to
d8eace3
Compare
Sorry, @minht11, can you please rebase another time? |
d8eace3
to
056449d
Compare
0398343
to
93b009a
Compare
Remove chai/mocha in favor of native node test runner and asserts.
Use tsx to load ts test files.
All tests but one pass.