Server stats #133
Server stats #133
Conversation
MatchmakingServer/Program.cs
Outdated
| @@ -199,4 +199,21 @@ [new Claim(ClaimTypes.Name, playerName), | |||
| return Results.SignIn(claimsPrincipal); | |||
| }); | |||
|
|
|||
| app.MapGet("/stats", (PlayerStore playerStore, ServerStore serverStore, PartyService partyService, Matchmaker matchmaker) => | |||
There was a problem hiding this comment.
I feel like the Program.cs file is getting quite lengthy.
It might be time to clean it up and extract how services are set up and how the app is build.
Furthermore, I if an endpoint changes or w/e, you shouldn't have to change the program.cs file.
I recommend to just make a controller for http request maps. It is just a bit better separation. (imo)
There was a problem hiding this comment.
Yeah we should definetely clean it up, same for the App.xaml.cs. I will create an issue for that, maybe i can clean it up as part of the multi-game refactoring.
I do like minimal api though it is more performant and... minimal :D So for single endpoints i think it makes sense. Would you be fine with putting them into seperate extension methods / classes?
There was a problem hiding this comment.
But isn't that just the same as adding a controller class? xD
There was a problem hiding this comment.
I see what you mean :D at first glance it looks the same but you dont have the slow controller pipeline and everything is more ✨ functional ✨. You only get the dependencies you need for that single endpoint.
Check out this example or REPR. There is this new trend towards vertical slice architecture. Not saying we should necessarily use that, but it definetely has advantages
There was a problem hiding this comment.
Can't you make it like that example? That would be nice. And it is out of the program cs
There was a problem hiding this comment.
Yes will do that. Also a good time to add some validation to the login endpoint
Clean up 'Program.cs' a bit Fix matchmaking namespace
No description provided.