more robust FEAT detect for non-standard impl

[MurmeltierS]

should fix #2

this implements the fix already present in ftpdeno nullobsi/ftpdeno@b0c6be8

Summary by CodeRabbit

• Refactor
  • Improved feature mapping logic in FTP functionality for more precise operation.

[coderabbitai]

Walkthrough

The update in the FTPClient class improves the feature detection mechanism by switching from includes to startsWith for the feats object. This change enhances the accuracy of feature recognition, specifically targeting the AUTH and PROT commands as part of improving FEAT support.

Changes

File Path	Change Summary
src/classes/ftp-client.ts	Updated feature mapping to use startsWith for better FEAT support.

Assessment against linked issues

Objective	Addressed	Explanation
Better support for FEAT (#2)	✅
Handle AUTH and PROT in FEAT (#11, #12)	❓	It's unclear if specific handling for AUTH and PROT has been implemented.

🐇✨
A hop, a skip, a code deploy,
In the land of bits, a joyous convoy.
From includes to startsWith we leap,
Ensuring our FTP feats are not cheap.
Cheers to changes, small and bright,
In the digital meadow, under the moonlight.
🌟🐰

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cfcd828 and f864de6.

Files selected for processing (1)

• src/classes/ftp-client.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/classes/ftp-client.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sntran]

There was another fix that handled specific cases of AUTH and PROT: nullobsi/ftpdeno@0d27140

[MurmeltierS]

@sntran sorry, overlooked that. will take a look tomorrow. otherwise, feel free to open a PR.