Fix issue with moving table view text.

- added higher quality placeholder image that wont shift text
BrentMifsud · Jun 2, 2019 · 5f31cfb · 5f31cfb
1 parent fb367e1
commit 5f31cfb
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 8 deletions.
diff --git a/.../PosterPlaceholder.imageset/Contents.json → ...s/MoviePlaceholder.imageset/Contents.json b/.../PosterPlaceholder.imageset/Contents.json → ...s/MoviePlaceholder.imageset/Contents.json
@@ -2,17 +2,15 @@
   "images" : [
     {
       "idiom" : "universal",
-      "filename" : "film_512.png",
+      "filename" : "Screen Shot 2019-06-01 at 5.33.23 PM.png",
       "scale" : "1x"
     },
     {
       "idiom" : "universal",
-      "filename" : "film_512-1.png",
       "scale" : "2x"
     },
     {
       "idiom" : "universal",
-      "filename" : "film_512-2.png",
       "scale" : "3x"
     }
   ],

diff --git a/...ets.xcassets/MoviePlaceholder.imageset/Screen Shot 2019-06-01 at 5.33.23 PM.png b/...ets.xcassets/MoviePlaceholder.imageset/Screen Shot 2019-06-01 at 5.33.23 PM.png
diff --git a/TheMovieManager/Assets/Assets.xcassets/PosterPlaceholder.imageset/film_512-1.png b/TheMovieManager/Assets/Assets.xcassets/PosterPlaceholder.imageset/film_512-1.png
diff --git a/TheMovieManager/Assets/Assets.xcassets/PosterPlaceholder.imageset/film_512-2.png b/TheMovieManager/Assets/Assets.xcassets/PosterPlaceholder.imageset/film_512-2.png
diff --git a/TheMovieManager/Assets/Assets.xcassets/PosterPlaceholder.imageset/film_512.png b/TheMovieManager/Assets/Assets.xcassets/PosterPlaceholder.imageset/film_512.png
diff --git a/TheMovieManager/Controller/FavoritesViewController.swift b/TheMovieManager/Controller/FavoritesViewController.swift
@@ -57,7 +57,7 @@ extension FavoritesViewController: UITableViewDataSource, UITableViewDelegate {
         let movie = MovieModel.favorites[indexPath.row]
 
         cell.textLabel?.text = movie.title
-		cell.imageView?.image = UIImage(named: "PosterPlaceholder")
+		cell.imageView?.image = UIImage(named: "MoviePlaceholder")
 
 		if let posterPath = movie.posterPath {
 			TMDBClient.downloadPosterImage(posterPath: posterPath) { (data, error) in

diff --git a/TheMovieManager/Controller/MovieDetailViewController.swift b/TheMovieManager/Controller/MovieDetailViewController.swift
@@ -28,9 +28,11 @@ class MovieDetailViewController: UIViewController {
         super.viewDidLoad()
 
         navigationItem.title = movie.title
-		imageView.image = UIImage(named: "PosterPlaceholder")
+		imageView.image = UIImage(named: "MoviePlaceholder")
 
-		TMDBClient.downloadPosterImage(posterPath: movie.posterPath ?? "", completion: handlePosterImageResponse(data:error:))
+		if let posterPath = movie.posterPath {
+			TMDBClient.downloadPosterImage(posterPath: posterPath, completion: handlePosterImageResponse(data:error:))
+		}
 
         toggleBarButton(watchlistBarButtonItem, enabled: isWatchlist)
         toggleBarButton(favoriteBarButtonItem, enabled: isFavorite)

diff --git a/TheMovieManager/Controller/SearchViewController.swift b/TheMovieManager/Controller/SearchViewController.swift
@@ -82,7 +82,7 @@ extension SearchViewController: UITableViewDataSource, UITableViewDelegate {
 			cell.textLabel?.text?.append(" - \(movie.releaseYear)")
 		}
 
-		cell.imageView?.image = UIImage(named: "PosterPlaceholder")
+		cell.imageView?.image = UIImage(named: "MoviePlaceholder")
 
 		if let posterPath = movie.posterPath {
 			TMDBClient.downloadPosterImage(posterPath: posterPath) { (data, error) in

diff --git a/TheMovieManager/Controller/WatchlistViewController.swift b/TheMovieManager/Controller/WatchlistViewController.swift
@@ -56,7 +56,7 @@ extension WatchlistViewController: UITableViewDataSource, UITableViewDelegate {
         let movie = MovieModel.watchlist[indexPath.row]
 
 		cell.textLabel?.text = movie.title
-		cell.imageView?.image = UIImage(named: "PosterPlaceholder")
+		cell.imageView?.image = UIImage(named: "MoviePlaceholder")
 
 		if let posterPath = movie.posterPath {
 			TMDBClient.downloadPosterImage(posterPath: posterPath) { (data, error) in