Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type fetch data usages #15363

Merged
merged 23 commits into from
Jan 16, 2025
Merged

Type fetch data usages #15363

merged 23 commits into from
Jan 16, 2025

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Jan 14, 2025

Description

Type fetch data usages

Copy link

qa-wolf bot commented Jan 14, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Jan 14, 2025
@adrinr adrinr marked this pull request as ready for review January 15, 2025 11:56
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a comment about how we handle typing like this - I've been trying to expand the UI typing in types, I think it saves some future effort when trying to import these.

@github-actions github-actions bot added size/l and removed size/m labels Jan 16, 2025
@adrinr adrinr merged commit 1b2a7a6 into master Jan 16, 2025
20 checks passed
@adrinr adrinr deleted the ts/type-fetchData-usages branch January 16, 2025 10:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants