BBUI TS scaffolding + helpers conversion #15385
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
| export let noPadding = false | ||
| export let weight = "default" // light, heavy, default | ||
| export let size: "XS" | "S" | "M" | "L" = "M" | ||
| export let textAlign: string | undefined = undefined |
There was a problem hiding this comment.
I think that the | undefined is not required, as it gets inferred by the = undefined
There was a problem hiding this comment.
You got me hopeful as I have done this in loads of places and would love to remove it!
But it does seem required. If I remove it:
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, I see. It's caused to adding the default tsconfig. The strictNullChecks is the culprit
There was a problem hiding this comment.
Ah I think I understand the difference. In this case textAlign actually is optional, so I want to type is as possibly undefined. If i change strictNullChecks to false then it lets me set it as undefined, but it is typed as string only which is incorrect for this use case and potentially dangerous (unless all our code was TS, then it would be easy to spot any errors).
I'll keep this as-is, because I think it's more correct for this use case, in that it actually is optional 👍
Description
This PR adds the required config so that BBUI can properly build typescript code in both svelte components and .ts files.
I've converted the helpers and the Heading component to TS as an example of both.
I've also added a
devscript so thatbbuiis continually built in dev, highlighting any build issues which may otherwise go unnoticed.