fixes Bunlong/next-qrcode#40 Deprecated old interfaces. Introduced 3 … #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rface for each of the qr types, i.e. Canvas, SVG and Image. Added inline comment for better developer experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Done:
<img>Note:
This may introduce breaking change, i.e. when someone uses
<Canvasbut provided an option prop oftype. The fix should be simple, delete that prop. Screenshot below shows the error caused by this breaking change, where it was possible to provide atypeprop to a Canvas in the past, but it is not relevant.