-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable original filename parameter #47
base: master
Are you sure you want to change the base?
Conversation
I was just wondering what I am doing wrong. I upvote the pull request as I would also need to do the same fix |
@nyroDev Sorry for the late response on this issue. I've ran some tests with the sample that we include in the SDK and I wasn't able to reproduce the issue that you mention. On these lines bynder-php-sdk/sample/sample.php Lines 123 to 129 in 8838eca
When passing the data as below, the name of the asset gets set as "PHP SDK Upload", the filepath isn't used within the DAM.
The original filename doesn't change the name of the actual file but it adds this as an extra field within the Info Pane on the asset detail page. |
@TimBloembergen I'm not sure to follow you. My Pull Request add the documented parameter I understand that regarding final user it won't make many change as the original filename is not used on the DAM side, but for my use case, the original file name is useful for the user as it will give some information on where it comes from. And it's documented on the API, so why don't support it? Maybe you want me to also update the |
@nyroDev We can definitely add it as it's part of the API! But it won't solve the issue that you described regarding the filepath being shown to the user. What are you passing as the payload so this happens? |
It's already part of the API! My PR just add the necessary in order to use the |
@TimBloembergen I still don't understand what is the problem here. |
According to the documentation, an
original_filename
could be used when uploading a file.Without it, the full path of the file is used and then shown to the end user, which is not great.
This PR simply enable the parameter to be used when saving the uploaded file as documented.