Added notifications to WaitableAtomic<>.
#995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzhurovich
reviewed
Apr 12, 2024
| }; | ||
|
|
||
| [[nodiscard]] | ||
| WaitableAtomicSubscriberScope Subscribe(std::function<void()> f) { |
There was a problem hiding this comment.
nit: Could be a bit confusing why subscribers aren't really getting any data as a part of subscription, but I can't come up with some better (but still concise) naming to clarify it's subscription to state change signals.
There was a problem hiding this comment.
gmta, leaving this in the back of my mind for some further PRs
(this code need a test too btw, which is not there yet!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.