Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the intruduced message parsing bug #43

Merged
merged 2 commits into from
May 27, 2024

Conversation

dzervas
Copy link
Collaborator

@dzervas dzervas commented May 26, 2024

I forgot to fix how projectUtils parse the wasm reply

The way that I'm handling the messages is not perfect yet but I'll work on it after ISOtope gets integrated

dzervas added 2 commits May 26, 2024 20:09
Signed-off-by: Dimitris Zervas <dzervas@dzervas.gr>
Signed-off-by: Dimitris Zervas <dzervas@dzervas.gr>
Copy link
Collaborator

@MattFerraro MattFerraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@@ -9,6 +9,25 @@ use crate::extrusion::{Direction, Extrusion, ExtrusionMode};
use crate::project::Project;
use crate::step::StepData;

#[derive(Tsify, Debug, Serialize, Deserialize)]
#[tsify(into_wasm_abi, from_wasm_abi)]
pub enum MessageResult {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh awesome. love this

@MattFerraro MattFerraro merged commit 238d3e2 into CADmium-Co:main May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants