Apply suggestions from code review

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
CBATeam · Aug 27, 2024 · 88ba4d4 · 88ba4d4
1 parent db969b3
commit 88ba4d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/addons/ui/fnc_getInventoryItemData.sqf b/addons/ui/fnc_getInventoryItemData.sqf
@@ -45,14 +45,7 @@ switch _containerType do {
     };
 };
 
-// Reports classname, but only for magazines.
+// Reports classname for every item type except backpacks (https://feedback.bistudio.com/T183096)
 private _classname = _control lbData _index;
-if (_classname isEqualTo "") then {
-    // For weapons, items and glasses, use the lb index and compare with cargo item list.
-    private _cargoItems = weaponCargo _container + itemCargo _container + magazineCargo _container;
-    _cargoItems = _cargoItems arrayIntersect _cargoItems;
-
-    _classname = _cargoItems param [_index, ""];
-};
 
 [_classname, _container, _containerType]
diff --git a/addons/ui/fnc_renameInventoryItem.sqf b/addons/ui/fnc_renameInventoryItem.sqf
@@ -42,3 +42,5 @@ if (isNull _config) exitWith { ERROR_1("Class [%1] does not exists",_class) };
 _class = configName _config; // Ensure class name is in config case
 
 GVAR(renamedItems) set [_class, [_name, _picture]];
+
+nil
Original file line number	Diff line number	Diff line change
Expand Up		@@ -42,3 +42,5 @@ if (isNull _config) exitWith { ERROR_1("Class [%1] does not exists",_class) };
		_class = configName _config; // Ensure class name is in config case

		GVAR(renamedItems) set [_class, [_name, _picture]];

		nil