Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Arriba for other genomes #90

Closed
kelly-sovacool opened this issue Jan 11, 2024 · 5 comments
Closed

Support Arriba for other genomes #90

kelly-sovacool opened this issue Jan 11, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request RENEE RepoName
Milestone

Comments

@kelly-sovacool
Copy link
Member

kelly-sovacool commented Jan 11, 2024

It only supports hg38 and mm10 by default. We may need to reach out to the Arriba maintainer for help creating these fusion files for other genome annotations.

"FUSIONBLACKLIST": "s3://nciccbr/Resources/RNA-seq/arriba/blacklist_hg38_GRCh38_v2.0.0.tsv.gz",
"FUSIONCYTOBAND": "s3://nciccbr/Resources/RNA-seq/arriba/cytobands_hg38_GRCh38_v2.0.0.tsv",
"FUSIONPROTDOMAIN": "s3://nciccbr/Resources/RNA-seq/arriba/protein_domains_hg38_GRCh38_v2.0.0.gff3"

@kopardev kopardev added the RENEE RepoName label Jan 11, 2024
@kelly-sovacool kelly-sovacool added the enhancement New feature or request label Jan 11, 2024
@kopardev
Copy link
Member

Linked to #12

@kopardev kopardev added this to the 2024-06 milestone May 21, 2024
@kelly-sovacool
Copy link
Member Author

there is likely an if statement checking for the genome and only running arriba on hg38 -- will need to remove this

@kelly-sovacool
Copy link
Member Author

kelly-sovacool commented Nov 4, 2024

hg19 blacklist and fusion files are included in arriba: https://arriba.readthedocs.io/en/latest/input-files/#blacklist

first let's download on biowulf, later will put them in our s3 bucket

@kelly-sovacool kelly-sovacool modified the milestones: 2024-06, 2024-11 Nov 4, 2024
@kelly-sovacool
Copy link
Member Author

there is likely an if statement checking for the genome and only running arriba on hg38 -- will need to remove this

this appears to be implemented correctly

if references(config, pfamily, ['FUSIONBLACKLIST', 'FUSIONCYTOBAND', 'FUSIONPROTDOMAIN']):

@kelly-sovacool
Copy link
Member Author

kelly-sovacool commented Dec 2, 2024

closing in favor of #12. All that is needed is to upload the mm39 resources to S3 and update the jsonmaker rule to support mm39

rule jsonmaker:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RENEE RepoName
Projects
None yet
Development

No branches or pull requests

2 participants