Add support for CEED_EVAL_GRADIENT and CEED_TRANSPOSE in CeedBasisApplyAtPoints
#1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatkins-dev
force-pushed
the
zach/basis-gradient-transpose-at-points
branch
from
cfb542b to
c4df5ae
Compare
jeremylt
reviewed
Oct 31, 2023
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
|
Do you think we should add a more robust gradient transpose test in this PR or is this good to merge? @jeremylt |
|
I'd say good to merge |
jedbrown
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR implements
CeedBasisApplyAtPointsfor the previously unsupportedCEED_EVAL_GRADIENTandCEED_TRANSPOSEoption.Additionally, it adds a test similar to
t314-basis.cto test the gradient transpose. We may want to consider an improved test for gradient transpose, both forCeedBasisApplyAtPointsandCeedBasisApply.