Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor performance improvement for op with repeat input rstr #1643

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

jeremylt
Copy link
Member

@jeremylt jeremylt commented Aug 5, 2024

This PR skips the duplicate restriction if two fields share the same input vector and restriction. I'd like to do this for output as well, but that's more involved. This should offer a very mild performance improvement for the linear damage model in Ratel.

@jrwrigh
Copy link
Collaborator

jrwrigh commented Aug 5, 2024

I has a similar thought the other day, but for composite operators. Do they share input E-Vecs that have the same restriction and vector, or are they recalculated as well?

@jeremylt
Copy link
Member Author

jeremylt commented Aug 5, 2024

I think its much less common that composite operators will share e-vecs in many cases. At least in our typical usage of composite operators I've seen, we tend to use them for different regions of the mesh, like faces vs volumes

@jrwrigh
Copy link
Collaborator

jrwrigh commented Aug 5, 2024

I was thinking about possibly including one of the SGS models as a sub-operator rather than a separate function call like it is right now, in which case there'd be a duplication of vectors there. But fair, it's pretty rare otherwise.

@jeremylt
Copy link
Member Author

jeremylt commented Aug 5, 2024

I'm planning on waiting unit Nother is back up to merge, but then I want to do the same thing on the output side once I create CeedBasisApplyAdd

@jeremylt jeremylt merged commit 50ca0d9 into main Aug 5, 2024
27 of 28 checks passed
@jeremylt jeremylt deleted the jeremy/less-rstr branch August 5, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants