-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-tensor shared #1721
Add non-tensor shared #1721
Conversation
5d36201
to
3e42d60
Compare
324c97e
to
c21b7ff
Compare
Edit: This is solved, it was a bad grid size for the weights kernel Investigating error on PETSc BP3:
|
Edit: This happens on my machine on main too, so its not related to this MR. Also - t354 is failing on my machine but not in CI, so that's odd. I thought it was my CUDA update causing troubles but it persists after restarting. |
c21b7ff
to
7c2945f
Compare
7c2945f
to
a3fb7fa
Compare
Ok, I need to actually test the HIP code, but we've got everything working on the CUDA side of the house. Edit: Confirmed the new code compiles on Noether, but still bringing my local dev machine back up to date to test
|
a3fb7fa
to
1f6c24f
Compare
This is a prereq for the long awaited */gen non-tensor support.