Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperbolic surface triangulation 2 (new package) #8259

Open
wants to merge 116 commits into
base: master
Choose a base branch
from

Conversation

loic-dubois
Copy link
Member

@loic-dubois loic-dubois commented Jun 5, 2024

Summary of Changes

This package enables building and handling triangulations of closed orientable hyperbolic surfaces: a basic tool for any future implementation of algorithms operating on such surfaces. Functionalities are offered such as the Delaunay flip algorithm, and the construction of a portion of the lift of the triangulation in the Poincaré disk model of the hyperbolic plane. Triangulations can be generated by triangulating a convex fundamental domain in the Poincaré disk. A method is offered that generates such domains in genus two.

Release Management

@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Feature labels Jun 5, 2024
@MaelRL MaelRL added this to the 6.1-beta milestone Jun 5, 2024
@MaelRL MaelRL changed the title Hyperbolic surface triangulation 2 dubois Hyperbolic surface triangulation 2 (new package) Jun 5, 2024
@afabri
Copy link
Member

afabri commented Jun 5, 2024

/build:v0

Copy link

github-actions bot commented Jun 5, 2024

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v0/Manual/index.html

@pougetma
Copy link
Member

pougetma commented Jan 8, 2025

/build:v1

Copy link

github-actions bot commented Jan 8, 2025

There was an error while building the doc:

/home/runner/work/cgal/cgal/Hyperbolic_surface_triangulation_2/doc/Hyperbolic_surface_triangulation_2/Hyperbolic_surface_triangulation_2.txt:20: warning: unable to resolve reference to 'Chapter_2D_Periodic_Hyperbolic_Triangulations' for \ref command
/home/runner/work/cgal/cgal/Periodic_4_hyperbolic_triangulation_2/doc/Periodic_4_hyperbolic_triangulation_2/Periodic_4_hyperbolic_triangulation_2.txt:20: warning: unable to resolve reference to 'Chapter_Hyperbolic_Surface_Triangulations' for \ref command

https://github.com/CGAL/cgal/actions/runs/12674566430

@sloriot
Copy link
Member

sloriot commented Jan 10, 2025

Please check CGAL-6.1-Ic-60 for errors and warnings.

@MaelRL MaelRL added Pkg:Triangulation_on_hyperbolic_surface_2 2D Triangulations on Hyperbolic Surfaces Ready to be tested and removed Tests failing labels Jan 17, 2025
@pougetma
Copy link
Member

When compiling examples or tests, it seems a file is missing:
#include <CGAL/license/Triangulation_on_hyperbolic_surface_2.h>
@MaelRL : did you forget to commit it?

@MaelRL
Copy link
Member

MaelRL commented Jan 20, 2025

When compiling examples or tests, it seems a file is missing: #include <CGAL/license/Triangulation_on_hyperbolic_surface_2.h> @MaelRL : did you forget to commit it?

No, the license file is there: https://github.com/CGAL/cgal/pull/8259/files#diff-74d7fd69497c42e2489e25b8ea8b5796a3debbff0098cb3243b636938b720994

@pougetma
Copy link
Member

When compiling examples or tests, it seems a file is missing: #include <CGAL/license/Triangulation_on_hyperbolic_surface_2.h> @MaelRL : did you forget to commit it?

No, the license file is there: https://github.com/CGAL/cgal/pull/8259/files#diff-74d7fd69497c42e2489e25b8ea8b5796a3debbff0098cb3243b636938b720994

Ok, thanks, so there must be something wrong with my Cmake config ...

@pougetma
Copy link
Member

/build:v1

Copy link

There was an error while building the doc:

/home/runner/work/cgal/cgal/Triangulation_on_hyperbolic_surface_2/doc/Triangulation_on_hyperbolic_surface_2/examples.txt:5: warning: included file Triangulation_on_hyperbolic_surface_2/hyperbolic_surface_triangulation.cpp is not found. Check your EXAMPLE_PATH
/home/runner/work/cgal/cgal/Triangulation_on_hyperbolic_surface_2/doc/Triangulation_on_hyperbolic_surface_2/Triangulation_on_hyperbolic_surface_2.txt:133: warning: included file Triangulation_on_hyperbolic_surface_2/hyperbolic_surface_triangulation.cpp is not found. Check your EXAMPLE_PATH

https://github.com/CGAL/cgal/actions/runs/12866464378

@pougetma
Copy link
Member

/build:v1

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v1/Manual/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGES.md not updated Feature Not yet approved The feature or pull-request has not yet been approved. Pkg:Triangulation_on_hyperbolic_surface_2 2D Triangulations on Hyperbolic Surfaces Ready to be tested TODO (web)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants