Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP PMP - add different smoothing options to PMP::isotropic_remeshing() #8648

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

WIP PMP - add different smoothing options to PMP::isotropic_remeshing() #8648

wants to merge 15 commits into from

Conversation

janetournois
Copy link
Member

@janetournois janetournois commented Dec 6, 2024 •
edited
Loading

Todo

  • transfer all named parameters to smoothing algorithms
  • use expand_vertex_selection_...() from BGL
  • improve UI
  • doc

Summary of Changes

Describe what your pull request changes to CGAL (this can be skipped if it solves an issue already in the tracker or if it is a Feature or Small Feature submitted to the CGAL Wiki).

Release Management

  • Affected package(s):
  • Issue(s) solved (if any): partially solves Improvements for PMP::isotropic_remeshing #1708
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

janetournois and others added 13 commits November 4, 2024 15:14
@janetournois
WIP use fairing as smoother for PMP::isotropic_remeshing()
ed26e18
@janetournois
there is no need to duplicate the call to tangential_relaxation()
af3c130
@janetournois
use PMP::fair() as another option for smoothing in PMP::isotropic_rem…
7c26150 
…eshing()
@janetournois
add relax_constraints option to smoothing with fair()
067d7a5
@janetournois
add constrained vertices to pmap
ec1d43a
@janetournois
add is_move_allowed(v) and use it in tangential_relaxation_impl()
b8165f6
@janetournois
remove unused
7462b70
@janetournois
vertex is constrained if NOT allowed to move
21e1ff1
@janetournois
Merge branch 'PMP-remeshing_fix_relaxation_of_constrained_vertices-jt…
903d752 
…ournois' into PMP-remeshing_with_fairing-jtournois
@janetournois
Merge remote-tracking branch 'cgal/master' into PMP-remeshing_with_fa…
f764407 
…iring-jtournois
@janetournois
fair() documentation
87100ce
@janetournois
add FAIR and SMOOTH_SHAPE options for smoothing_algorithm()
158b870
@janetournois
add smoothing options to Isotropic_remeshing_plugin
b4f3d75
@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Small feature CHANGES.md not updated labels Dec 16, 2024
@MaelRL MaelRL added this to the 6.1-beta milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CHANGES.md not updated Not yet approved The feature or pull-request has not yet been approved. Pkg::PMP Small feature Work in progress
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@janetournois @MaelRL