Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost::optional with std::optional #8695

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Replace boost::optional with std::optional #8695

merged 2 commits into from
Jan 20, 2025

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented Jan 16, 2025

Summary of Changes

Some occurrences that slipped through.

See #7526

Release Management

  • Affected package(s): Tetrahedral_remeshing, Triangulation_3
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): -
  • License and copyright ownership: no change

@MaelRL MaelRL added this to the 6.0.2 milestone Jan 16, 2025
@MaelRL MaelRL requested a review from janetournois January 16, 2025 12:50
@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. Ready to be tested labels Jan 16, 2025
@MaelRL @SharonIV0x86
Use std::optional::reset
72520db 
Co-authored-by: Anirudh Lakhanpal <91114837+SharonIV0x86@users.noreply.github.com>
@SharonIV0x86
Copy link
Contributor

So, CGAL now no longer uses boost::optional and only uses the std::optional?

@sloriot
Copy link
Member

sloriot commented Jan 20, 2025

Successfully tested in CGAL-6.1-Ic-66

@sloriot sloriot added Tested and removed Ready to be tested Under Testing Not yet approved The feature or pull-request has not yet been approved. labels Jan 20, 2025
@sloriot sloriot merged commit 816cd11 into CGAL:6.0.x-branch Jan 20, 2025
8 of 9 checks passed
@sloriot sloriot deleted the CGAL-Remove_boost_opt_variant-GF branch January 20, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharonIV0x86 SharonIV0x86 SharonIV0x86 left review comments

@janetournois janetournois Awaiting requested review from janetournois

Assignees
No one assigned
Labels
Cleaning Pkg::Tetrahedral_remeshing Pkg::Triangulation_3 Tested
Projects
None yet
Milestone
6.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@MaelRL @SharonIV0x86 @sloriot