Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params DB UI Improvements and Climate Parameter Adjustments #2

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

elaouniyassine
Copy link
Collaborator

This PR introduces the following changes:

  • Specific tables have been hidden from the user interface as per the request.
  • Improved readability by ensuring all parameters database tab names are capitalized appropriately.
  • Replaced instances of "warm" with "tropical" in climate-related parameters for accuracy, as requested.

Copy link
Collaborator

@ahmedjoubest ahmedjoubest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Yassine!

Let's merge this to staging after addressing these three points:

  1. For the "Hide 13 parameters db tables from UI, as requested" commit, we need to confirm with @M-Emmanuel and Rein that they agree on the double hidden inputs issue, particularly regarding inputs defaulting to 0 and being hidden in both the scenario and params databases.
  2. For the "Adjust climate parameters: warm changed to tropical" commit:
    • We should discuss with Emmanuel how user data on the server should systematically reflect these changes.
    • While we've updated the main sources (default_data, primary_database, and shared folder), userdata on the server remains unchanged. Manual updates for each user would be inefficient, so we need a team discussion on an automated solution for this, especially if params db is meant to evolve more in the future.
  3. For the same commit, ensure the examples in the shared drive are updated to reflect these changes as well.

@M-Emmanuel
Copy link
Collaborator

If Monday at 8 pm EAT works for all (including Rein), we can discuss points 1 and 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants