Fix Lombok strait + add cf-xarray functionality in Transport_Through_Straits.ipynb
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
navidcy
added
🛸 updating
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-02-22T22:37:26Z Line #14. logging.warning('North of 65N the tripolar grid geometry brings complications and .sum(''xt_ocean'') is wrong!')
I guess this warning text can be revised if using CF coordinates. (i.e. summing over longitude is wrong?) |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-02-22T22:37:27Z Line #4. transport.plot(); Maybe this title can have a better title than 'xu_ocean = ...', e.g. Longitude = |
|
thanks @anton-seaice; I've dealt with everything. |
anton-seaice
approved these changes
Feb 22, 2024
navidcy
changed the title
cf-xarray functionalitycf-xarray functionality in Transport_Through_Straits.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Lombok strait that was giving zero transport + sprinkles with
.cffrom cf-xarray to use conventional dimension names.