-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(v0.6.0) Simplify boundary condition construction #175
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
In this PR you're changing the initial condition function to also do the boundary right? I still think that the boundary and initial conditions should be kept as separate functions. If not, then we'll should rename it so that the "initial condition" function doesn't do the boundary right? This is confusing to me Perhaps we copy - paste the 'iterate over boundaries' file to the |
Oh my bad |
This PR will require a new tag release as it's not backwards compatible. Also need to update the access om2 example with the changes. |
I'm going to approve the PR because it was Navid's originally. Wait on merging until @navidcy is happy and we also fix up the access om2 example to match simultaneously |
I'd like to merge this and then we tag a new release -- how does this sound @ashjbarnes? |
Great! Need to reflect changes in access om2 example |
Description edited by Ashley to reflect discussion below
This PR aims to simplify the boundary condition construction in the simple case of four boundaries that are parallel to lines of constant longitude and latitude, as per the discussion in #174.
To do this, we add a wrapper function that just calls the
simple_boundary
method for each cardinal direction requested.This PR includes a breaking API change since
rectangular_boundary
is renamed torectangular_boundaries
and also some of its args changed.Closes #174