-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/docs/18 docs update #20
Conversation
5bd5f04
to
a2c0403
Compare
7b81257
to
512b636
Compare
2c58df8
to
a764878
Compare
be76886
to
533b437
Compare
|
||
```json | ||
"target_definitions": { | ||
"linux--b49069c2-0b69-4a46-8509-80196c4a9bf8": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux is not a valid target in soarca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually use the type
of targets anywhere, right? And linux
is a target type in the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No but this gives the impression it is possible which is not
|
||
### If-condition, while-condition, and parallel steps | ||
|
||
An `if-condition` step allows executing different branches depending on a specified condition. The step must specify an `on_true` field, which references the start of a branch of steps that should be executed if the condition evaluates to true. Optionally, the `if-condition` step can define an `on_false` field that defines an alternative branch that is executed if the condition evaluates to false. In each case, the specified branch keeps executing until it encounters an `end` step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucamrgs and @MaartendeKruijf discussed this but this makes for difficult execution, which also makes execution paths a bit tricky we will take this up with the TC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think understand your issue. It's that you need to keep track of the current branch and where it started. A brand-end
step could then specify the head of the branch so it's simpler to move onto the next step on that level, right?
533b437
to
5e0df18
Compare
This reverts commit 58325ae.
f042917
to
0e54208
Compare
No description provided.