[BUGFIX] Respect extension configuration for helper registration

CPS-IT · Jan 7, 2025 · 954f64e · 954f64e
1 parent d744729
commit 954f64e
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 10 deletions.
diff --git a/Classes/Renderer/Helper/BlockHelper.php b/Classes/Renderer/Helper/BlockHelper.php
@@ -23,7 +23,6 @@
 
 namespace Fr\Typo3Handlebars\Renderer\Helper;
 
-use Fr\Typo3Handlebars\Attribute;
 use Fr\Typo3Handlebars\Exception;
 use Fr\Typo3Handlebars\Renderer;
 
@@ -34,7 +33,6 @@
  * @license GPL-2.0-or-later
  * @see https://github.com/shannonmoeller/handlebars-layouts#block-name
  */
-#[Attribute\AsHelper('block')]
 final readonly class BlockHelper implements HelperInterface
 {
     /**

diff --git a/Classes/Renderer/Helper/ContentHelper.php b/Classes/Renderer/Helper/ContentHelper.php
@@ -23,7 +23,6 @@
 
 namespace Fr\Typo3Handlebars\Renderer\Helper;
 
-use Fr\Typo3Handlebars\Attribute;
 use Fr\Typo3Handlebars\Renderer;
 use Psr\Log;
 
@@ -34,7 +33,6 @@
  * @license GPL-2.0-or-later
  * @see https://github.com/shannonmoeller/handlebars-layouts#content-name-modeappendprependreplace
  */
-#[Attribute\AsHelper('content')]
 final readonly class ContentHelper implements HelperInterface
 {
     private const DEFAULT_MODE = Renderer\Component\Layout\HandlebarsLayoutActionMode::Replace;

diff --git a/Classes/Renderer/Helper/ExtendHelper.php b/Classes/Renderer/Helper/ExtendHelper.php
@@ -23,7 +23,6 @@
 
 namespace Fr\Typo3Handlebars\Renderer\Helper;
 
-use Fr\Typo3Handlebars\Attribute;
 use Fr\Typo3Handlebars\Renderer;
 
 /**
@@ -33,7 +32,6 @@
  * @license GPL-2.0-or-later
  * @see https://github.com/shannonmoeller/handlebars-layouts#extend-partial-context-keyvalue-
  */
-#[Attribute\AsHelper('extend')]
 final readonly class ExtendHelper implements HelperInterface
 {
     public function __construct(

diff --git a/Classes/Renderer/Helper/RenderHelper.php b/Classes/Renderer/Helper/RenderHelper.php
@@ -23,7 +23,6 @@
 
 namespace Fr\Typo3Handlebars\Renderer\Helper;
 
-use Fr\Typo3Handlebars\Attribute;
 use Fr\Typo3Handlebars\DataProcessing;
 use Fr\Typo3Handlebars\Exception;
 use Fr\Typo3Handlebars\Renderer;
@@ -38,7 +37,6 @@
  * @license GPL-2.0-or-later
  * @see https://github.com/frctl/fractal/blob/main/packages/handlebars/src/helpers/render.js
  */
-#[Attribute\AsHelper('render')]
 final readonly class RenderHelper implements HelperInterface
 {
     public function __construct(

diff --git a/Tests/Unit/DependencyInjection/FeatureRegistrationPassTest.php b/Tests/Unit/DependencyInjection/FeatureRegistrationPassTest.php
@@ -117,7 +117,7 @@ private static function assertHelperIsTagged(DependencyInjection\ContainerBuilde
         $serviceIds = $container->findTaggedServiceIds('handlebars.helper');
         $expectedConfiguration = [
             'identifier' => $name,
-            'method' => 'evaluate',
+            'method' => 'render',
         ];
 
         self::assertArrayHasKey($className, $serviceIds);

diff --git a/Tests/Unit/Renderer/Helper/VarDumpHelperTest.php b/Tests/Unit/Renderer/Helper/VarDumpHelperTest.php
@@ -47,7 +47,7 @@ protected function setUp(): void
     }
 
     #[Framework\Attributes\Test]
-    public function evaluateReturnsDumpedContext(): void
+    public function renderReturnsDumpedContext(): void
     {
         Core\Utility\DebugUtility::useAnsiColor(false);