Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Introduce #[AsHelper] attribute for helper DI registration #374

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

eliashaeussler
Copy link
Member

This PR introduces a new #[AsHelper] attribute. It can be used for auto-registration of Handlebars helpers. In addition, existing DI configuration is migrated to attributes where applicable.

@eliashaeussler eliashaeussler added the enhancement New feature or request label Dec 17, 2024
@eliashaeussler eliashaeussler self-assigned this Dec 17, 2024
@eliashaeussler eliashaeussler changed the title [FEATURE] Introduce #[AsHelper] attribute for helper DI registration [FEATURE] Introduce #[AsHelper] attribute for helper DI registration Dec 17, 2024
@coveralls
Copy link
Collaborator

coveralls commented Dec 17, 2024

Pull Request Test Coverage Report for Build 12391845945

Details

  • 5 of 8 (62.5%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 89.53%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/Renderer/Helper/BlockHelper.php 0 1 0.0%
Classes/Attribute/AsHelper.php 0 2 0.0%
Totals Coverage Status
Change from base Build 12371013941: -0.2%
Covered Lines: 667
Relevant Lines: 745

💛 - Coveralls

@eliashaeussler eliashaeussler force-pushed the feature/1.x/di branch 3 times, most recently from b11f6f2 to 1716481 Compare December 18, 2024 10:08
@eliashaeussler eliashaeussler merged commit 72c02d1 into 1.x Dec 19, 2024
9 of 10 checks passed
@eliashaeussler eliashaeussler deleted the feature/1.x/di branch December 19, 2024 07:37
@eliashaeussler eliashaeussler added this to the v1.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants