Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][TASK] Streamline view configuration across path providers #385

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

eliashaeussler
Copy link
Member

This PR streamlines the view configuration of all template path providers by renaming the global root path configuration in service container from template to view:

 # Configuration/Services.yaml

 handlebars:
   default_data: []
-  template:
+  view:
     templateRootPaths: []
     partialRootPaths: []

@eliashaeussler eliashaeussler added breaking This introduces a breaking change maintenance Code base is being maintained labels Jan 7, 2025
@eliashaeussler eliashaeussler self-assigned this Jan 7, 2025
@eliashaeussler eliashaeussler merged commit e25b6fd into 1.x Jan 7, 2025
9 checks passed
@eliashaeussler eliashaeussler deleted the task/1.x/view-parameter branch January 7, 2025 17:59
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12656676453

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.798%

Totals Coverage Status
Change from base Build 12656556003: 0.0%
Covered Lines: 847
Relevant Lines: 903

💛 - Coveralls

@eliashaeussler eliashaeussler added this to the v1.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This introduces a breaking change maintenance Code base is being maintained
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants