Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Populate and read cacheable state of template path providers #398

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

eliashaeussler
Copy link
Member

This PR extends the PathProvider interface by an isCacheable method. It describes the possibility of path providers to provide cached root paths. This information is used in TemplatePaths when building final root paths.

@eliashaeussler eliashaeussler added the enhancement New feature or request label Jan 15, 2025
@eliashaeussler eliashaeussler self-assigned this Jan 15, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12791232068

Details

  • 16 of 20 (80.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 93.186%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/Renderer/Template/Path/GlobalPathProvider.php 0 2 0.0%
Classes/Renderer/Template/Path/TypoScriptPathProvider.php 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
Classes/Renderer/Template/Path/GlobalPathProvider.php 1 63.64%
Totals Coverage Status
Change from base Build 12790584286: -0.3%
Covered Lines: 971
Relevant Lines: 1042

💛 - Coveralls

@eliashaeussler eliashaeussler force-pushed the feature/1.x/cacheable branch 2 times, most recently from 4dbfbdb to 9f6f27b Compare January 15, 2025 15:03
@eliashaeussler eliashaeussler merged commit 6546a4c into 1.x Jan 15, 2025
9 of 10 checks passed
@eliashaeussler eliashaeussler deleted the feature/1.x/cacheable branch January 15, 2025 15:13
@eliashaeussler eliashaeussler added this to the v1.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants