Skip to content

Commit

Permalink
Change Boundary Arguments to __init__ and adjust respective functions…
Browse files Browse the repository at this point in the history
… + tests (#30)

* Package type changes for CRR

* Black Formatting

* Change MOM Param

* Change MOM_param to Work

* black

* Revert back to reg

* Add tide boundary flexibility

* Update Config to only vars

* Update Write and Read Config for computer independence

* Update Read/Write Config for Computer Independenc

* Fix Change MOM Param Issues

* Fix bug in __getattr__ and comment out matplotlib dependencies in demo

* Package type changes for CRR

* Black Formatting

* Add Boundaries to Init part 1

* black formatting

* Changing Boundary Def to __init__ pt 2

* Minor Bugs

* Make Direction Dir a one-time calculation because keys() doesn't gaurentee order

* Rearrange handling boundaries in __init__ to a boundary array and segments dict in the boundary functions ocean_state and tides

* Clean

* Improve commenting on setuop_ocean_state_boundaries

* Fix bug in declaring number of OBC segments

* Minor Big in override

* Add boundaries to config
  • Loading branch information
manishvenu authored Oct 24, 2024
1 parent 7d7216e commit 90e90a6
Show file tree
Hide file tree
Showing 6 changed files with 82 additions and 78 deletions.
Empty file added __init__.py
Empty file.
11 changes: 5 additions & 6 deletions demos/reanalysis-forced.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@
" minimum_depth = 5,\n",
" mom_run_dir = run_dir,\n",
" mom_input_dir = input_dir,\n",
" toolpath_dir = toolpath_dir\n",
" toolpath_dir = toolpath_dir,\n",
" boundaries=[\"north\", \"south\", \"east\", \"west\"]\n",
")"
]
},
Expand Down Expand Up @@ -191,8 +192,7 @@
"outputs": [],
"source": [
"expt.get_glorys_rectangular(\n",
" raw_boundaries_path=glorys_path,\n",
" boundaries=[\"north\", \"south\", \"east\", \"west\"],\n",
" raw_boundaries_path=glorys_path\n",
")"
]
},
Expand Down Expand Up @@ -285,7 +285,6 @@
"expt.setup_ocean_state_boundaries(\n",
" glorys_path,\n",
" ocean_varnames,\n",
" boundaries = [\"south\", \"north\", \"west\", \"east\"],\n",
" arakawa_grid = \"A\"\n",
" )"
]
Expand Down Expand Up @@ -429,7 +428,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "vroom_clean_env",
"display_name": "crr_dev",
"language": "python",
"name": "python3"
},
Expand All @@ -443,7 +442,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.6"
"version": "3.12.7"
}
},
"nbformat": 4,
Expand Down
Loading

0 comments on commit 90e90a6

Please sign in to comment.