forked from COSIMA/regional-mom6
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tides on angled boundaries, consolidate regridded of velocity and tracers, add proper body tide parameters, add MOM6's angle calculation. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GFDL rotation code was commented out🙈
Because this is such a big change... I'm doing dev in a branch of crr (there's no reason for it to be there other than version control) https://github.com/CROCODILE-CESM/crocodile-regional-ruckus/tree/support_tides_clean_branch/tides_dev Currently a good way through the merging and some progress on the tides bug. |
* Remove extra directories created * Black * Clean up created dirs
- correct the first arg of a classmethod (from self to cls). - introduce optional write_to_file arg in setup_bathymetry. - introduce optional bathymetry obj arg in tidy_bathymetry.
…filenames. Similarly, add thickesses arg to _make_vgrid.
alperaltuntas
requested changes
Jan 9, 2025
Solution to original bug:
|
FYI: Discussion with Alper offline, decided to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22, Closes #31
This PR address three problems/improvements in RM6:
Major Changes:
get_boundary_mask
,mask_boundary
)Minor Changes:
diag_table
get_glorys_rectangular
toget_glorys
Personal notes that might be easier to understand: https://docs.google.com/document/d/1pgpuFPhGon3mMdP4vj_8KbHp3AkKzoCbT7JS9KACdjU/edit?usp=sharing