-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with MacOS arm libtorch #183
Comments
@TomMelt Any chance we can prioritise this for the hackathon? |
TomMelt
added a commit
that referenced
this issue
Nov 19, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
TomMelt
added a commit
that referenced
this issue
Nov 19, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
TomMelt
added a commit
that referenced
this issue
Nov 19, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
TomMelt
added a commit
that referenced
this issue
Dec 2, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
TomMelt
added a commit
that referenced
this issue
Dec 4, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
TomMelt
added a commit
that referenced
this issue
Dec 9, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
TomMelt
added a commit
that referenced
this issue
Dec 10, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
TomMelt
added a commit
that referenced
this issue
Dec 10, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
TomMelt
added a commit
that referenced
this issue
Dec 10, 2024
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building github runners and locally suggests there is an issue with the macOS version of libtorch outputting different types compared to linux for the functions introduced in #175 .
FTorch expects a
long int*
whilst the libtorch binary seems to be returning along long int*
.Example output below.
The text was updated successfully, but these errors were encountered: