[TEST: DO NOT MERGE] Long long fix mac test #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integer size for FTorch can now be controlled using parameter `ftorch_int`. Currently, the default is set to `int32` but this could be changed if required. This fixes an issue on windows with the latest version of ifx/ifort which builds with a different integer type leading to the following error: ``` error #6284: There is no matching specific function for this generic function reference. [TORCH_TENSOR_FROM_ARRAY] in_tensors(1) = torch_tensor_from_array(in_data, tensor_layout, torch_kCPU) -------------------^ ```
fixes [#183](#183) There is an issue when building on mac (arm_64) or windows. The version of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a `const long long int*` instead of just a `const long int*` like on linux and mac (x86). This commit adds preprocessor macro to switch between implementations automatically detecting the correct version at CMake build stage.
…ccess intel compilers.
jatkinson1000
force-pushed
the
long-long-fix-mac-test
branch
from
c9f9b01 to
b58e93b
Compare
jatkinson1000
force-pushed
the
long-long-fix-mac-test
branch
from
b58e93b to
0a0e7e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that #137 and #191 by @TomMelt are running OK on mac by using the github runner actions on mac and intel set up in #164 by @jatkinson1000
If this combination runs OK in the workflows we can merge associated PRs.