Add developer guide page #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi All, think this is ready for review. |
jwallwork23
requested changes
Apr 9, 2024
TomMelt
reviewed
Apr 9, 2024
TomMelt
reviewed
Apr 9, 2024
TomMelt
approved these changes
Apr 9, 2024
ElliottKasoar
requested changes
Apr 9, 2024
There was a problem hiding this comment.
This looks great, thanks @jatkinson1000! This more than addresses the issue I raised, which is good approach since if we'd just added a starting point for documentation there'd be less motivation.
I think the link in the README is the only thing that needs checking, although I think I agree with all of the comments too.
jwallwork23
approved these changes
Apr 10, 2024
… rather than ICCS admin.
|
@ElliottKasoar If you are happy and can remove your request changes I'll get this squashed and merged. |
dorchard
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Add developer guide page * Update README with link to developer docs. * Update developer pages following review from JW, EK, and TM. * Update developer pages to use jwa34 personal email as a contact point rather than ICCS admin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #106
Adds guidance for developers: