Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move input array checks out of autograd example #231

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jwallwork23
Copy link
Contributor

Towards #211.
Follows #225.

This PR cuts down the amount of testing done in the autograd example. In particular, it moves the checks that input arrays aren't modified into the unit tests.

The PR also adds a missing summary for the autograd example in examples/README.md.

@jwallwork23 jwallwork23 added autograd Tasks towards the online training / automatic differentiation feature testing Related to FTorch testing labels Jan 13, 2025
@jwallwork23 jwallwork23 self-assigned this Jan 13, 2025
@jwallwork23
Copy link
Contributor Author

Just pushed a couple of commits because I realised that the cleanup subroutines weren't being used everywhere. Further, the shape checks were redundant because shape checking is already done in the assert_allclose subroutines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autograd Tasks towards the online training / automatic differentiation feature testing Related to FTorch testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant