Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure strides array initialised to zero #237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Jan 14, 2025

While working on #236, I hit an overflow error in the 3D torch_tensor_from_array unit test. Digging into it, I noticed that the strides array in torch_tensor_from_blob is not initialised to zero!

I also switched tensor_shape and layout to be assumed shape as I don't think assumed size is necessary.

@jwallwork23 jwallwork23 added the bug Something isn't working label Jan 14, 2025
@jwallwork23 jwallwork23 self-assigned this Jan 14, 2025
@jwallwork23
Copy link
Contributor Author

@jatkinson1000 and I had a discussion with @SimonClifford and determined that the same assumed shape change should be made else where - see 190782a. It still needs to be assumed size in the C interfaces because assumed shape is not interoperable - see https://stackoverflow.com/questions/38349435/in-fortran2003-is-1d-assumed-shape-array-interoperable-with-c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant