forked from pimcore/pimcore
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleanup task for directories #19
Open
zoidbergx
wants to merge
25
commits into
10.6
Choose a base branch
from
10.6-cleanup-directory-task
base: 10.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
zoidbergx
changed the title
wip: first draft of cleanup task
feat: cleanup task for directories
Jul 6, 2023
zoidbergx
pushed a commit
that referenced
this pull request
Jan 8, 2024
…roduced a requirement on the settings-store when building the PHP classes of class definitions (#19)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This is a followup of pimcore#14688 as we've had troubles that still some tmp files fill up our storage.
In the above PR the solution is to delete tmp files in my understanding like following:
if a Temp-File gets created via
File::getLocalTempFilePath()
https://github.com/pimcore/pimcore/blob/10.6/lib/File.php#L237 then the path of the tmp file is registered and gets cleanup either by:For example if the PHP process has a Segfault or if your container (in our case a Pod) has a memory overflow also the shutdown function is not executed so the tmp file lives forever in your storage.
To overcome this I implemented a simple clean up task in a general way to clean up a configured directory with all files older than a configured value. As default I added both tmp directories where old files always should be deletable.
In the same move I also cleaned up the HousekeepingTask and removed some old references where in the newly created Task is used.
It is lean against some part that exists back in V6.9: https://github.com/pimcore/pimcore/blob/6.9/lib/Maintenance/Tasks/HousekeepingTask.php#L48
Resolves #
Additional info
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough