Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup task for directories #19

Open
wants to merge 25 commits into
base: 10.6
Choose a base branch
from

Conversation

zoidbergx
Copy link
Member

@zoidbergx zoidbergx commented Jul 5, 2023

Changes in this pull request

This is a followup of pimcore#14688 as we've had troubles that still some tmp files fill up our storage.
In the above PR the solution is to delete tmp files in my understanding like following:

if a Temp-File gets created via File::getLocalTempFilePath()https://github.com/pimcore/pimcore/blob/10.6/lib/File.php#L237 then the path of the tmp file is registered and gets cleanup either by:

For example if the PHP process has a Segfault or if your container (in our case a Pod) has a memory overflow also the shutdown function is not executed so the tmp file lives forever in your storage.

To overcome this I implemented a simple clean up task in a general way to clean up a configured directory with all files older than a configured value. As default I added both tmp directories where old files always should be deletable.
In the same move I also cleaned up the HousekeepingTask and removed some old references where in the newly created Task is used.

It is lean against some part that exists back in V6.9: https://github.com/pimcore/pimcore/blob/6.9/lib/Maintenance/Tasks/HousekeepingTask.php#L48

Resolves #

Additional info

WHAT

copilot:summary

copilot:poem

HOW

copilot:walkthrough

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Bug fix: check if files are affected that were moved to a bundle - create a PR there if applicable
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@zoidbergx zoidbergx changed the title wip: first draft of cleanup task feat: cleanup task for directories Jul 6, 2023
zoidbergx pushed a commit that referenced this pull request Jan 8, 2024
…roduced a requirement on the settings-store when building the PHP classes of class definitions (#19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants