ZK-611: contract deployment environments #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kroist
commented
Dec 11, 2024
Comment on lines
-18
to
-23
| -z '${{ vars.CI_TESTNET_ALICE_PUBLIC_KEY }} }}' || \ | ||
| -z '${{ vars.CI_TESTNET_BOB_PUBLIC_KEY }} }}' || \ | ||
| -z '${{ vars.CI_TESTNET_CHARLIE_PUBLIC_KEY }} }}' || \ | ||
| -z '${{ vars.CI_TESTNET_TS_SDK_PUBLIC_KEY }} }}' || \ | ||
| -z '${{ vars.CI_TESTNET_RELAYER_SIGNER_ADDRESSES }} }}' || \ | ||
| -z '${{ vars.CI_TESTNET_FEE_DESTINATION }} }}' |
There was a problem hiding this comment.
this was NOT working
mikogs
reviewed
Dec 12, 2024
| default: "testnet-dev" | ||
| type: choice | ||
| options: | ||
| - "testnet-dev" |
There was a problem hiding this comment.
Please update this PR with latest changes. I have modified the environments to be dev, stage and prod (without the chain environment in the name).
| # for "testnet-dev" we use default owner address, as it's not important | ||
| - name: Set environment-specific variables | ||
| run: | | ||
| if [ "${{ github.event.inputs.environment }}" == "testnet-dev" ]; then |
There was a problem hiding this comment.
Just as in the previous comment - change the env name
| @@ -85,6 +110,19 @@ jobs: | |||
|
|
|||
| cat contract_spec_with_block_numbers.json | |||
|
|
|||
| - name: Determine address to store | |||
| run: | | |||
| if [ "${{ github.event.inputs.environment }}" == "testnet-dev" ]; then | |||
fbielejec
reviewed
Dec 12, 2024
| @@ -12,8 +12,9 @@ contract DeployShielderScript is Script { | |||
| function run() external { | |||
| uint256 privateKey = vm.envUint("PRIVATE_KEY"); | |||
There was a problem hiding this comment.
maybe we could rename it to DEPLOYER_PRIVATE_KEY for consistency with the Actions env vars?
fbielejec
approved these changes
Dec 12, 2024
mikogs
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.