Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relayer running script #68

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix relayer running script #68

merged 2 commits into from
Dec 23, 2024

Conversation

pmikolajczyk41
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 commented Dec 23, 2024 •
edited
Loading

  1. Do not require node port variable
  2. Fix 'bug': when running relayer on MacOS, relayer would only connect to a node running locally in a docker network. Now, for local tests, you just have to pass http://host.docker.internal:8545 or something like this.
  3. Add variable quotations

nightly pass: https://github.com/Cardinal-Cryptography/zkOS-monorepo/actions/runs/12464525940

@github-actions GitHub Actions
Copy link

Transaction NameMainCurrentDifference (%)
NewAccountNative20002632000215-0.00240%
DepositNative18278491827837-0.00066%
WithdrawNative18980331897997-0.00190%

@pmikolajczyk41 pmikolajczyk41 mentioned this pull request Dec 23, 2024
Closed
@pmikolajczyk41 pmikolajczyk41 merged commit 1988b8b into main Dec 23, 2024
16 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the fix-nightly branch December 23, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcin-Radecki Marcin-Radecki Marcin-Radecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmikolajczyk41 @Marcin-Radecki