Ignore transaction deserialization error #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
guspiel
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to alloy-rs: alloy-rs/alloy#1613 ensures (during node's response deserialization) that an untagged transaction doesn't have 'type' property specified. While our local environment won't contain such, Testnet blocks contain untagged legacy txs with a type property.
To avoid being blocked on alloy
0.4.x, I have reworked a bit recovery code in CLI, so that we can ignore this kind of errors. Nightly should be fine again: https://github.com/Cardinal-Cryptography/zkOS-monorepo/actions/runs/12586018143changes: