ZK-643: add circuits&secrets to shielder_bindings crate #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fbielejec
reviewed
Jan 14, 2025
fbielejec
reviewed
Jan 14, 2025
fbielejec
approved these changes
Jan 14, 2025
pmikolajczyk41
approved these changes
Jan 14, 2025
crates/shielder_bindings/build.rs
Outdated
Comment on lines
1
to
5
| /// This script builds artifacts, which are later | ||
| /// embedded into the wasm binary. | ||
| /// To speedup the build process, we cache the artifacts after the first build. | ||
| /// | ||
| /// When working locally, the `artifacts/` directory should be cleaned after the circuits are changed. |
crates/shielder_bindings/build.rs
Outdated
| gen_deposit(&full_params); | ||
| generate_new_account(&full_params); | ||
| generate_withdraw(&full_params); | ||
| println!("cargo:rerun-if-changed=../shielder-circuits"); |
There was a problem hiding this comment.
does it matter when we print? in particular, should we print this before heavy work?
There was a problem hiding this comment.
yeah it matters, moved to the top
| } | ||
|
|
||
| impl From<halo2_proofs::plonk::Error> for VerificationError { | ||
| fn from(error: halo2_proofs::plonk::Error) -> Self { |
There was a problem hiding this comment.
you might want to ensure that the variant makes sense in this context to avoid confusing error propagation
There was a problem hiding this comment.
not sure how to check the variant, there are plenty of them and they all are low-level
Comment on lines
36
to
75
| impl WasmCircuit for Circuit<DepositProverKnowledge<F, RANGE_PROOF_CHUNK_SIZE>> { | ||
| fn load_files() -> (Params, ProvingKey, u32) { | ||
| let params = unmarshall_params(include_bytes!("../../artifacts/deposit/params.bin")) | ||
| .expect("Failed to unmarshall params"); | ||
|
|
||
| let (k, pk) = unmarshall_pk::< | ||
| <DepositProverKnowledge<F, RANGE_PROOF_CHUNK_SIZE> as ProverKnowledge<F>>::Circuit, | ||
| >(include_bytes!("../../artifacts/deposit/pk.bin")) | ||
| .expect("Failed to unmarshall pk"); | ||
|
|
||
| (params, pk, k) | ||
| } | ||
| } | ||
|
|
||
| impl WasmCircuit for Circuit<NewAccountProverKnowledge<F>> { | ||
| fn load_files() -> (Params, ProvingKey, u32) { | ||
| let params = unmarshall_params(include_bytes!("../../artifacts/new_account/params.bin")) | ||
| .expect("Failed to unmarshall params"); | ||
| let (k, pk) = | ||
| unmarshall_pk::<<NewAccountProverKnowledge<F> as ProverKnowledge<F>>::Circuit>( | ||
| include_bytes!("../../artifacts/new_account/pk.bin"), | ||
| ) | ||
| .expect("Failed to unmarshall pk"); | ||
|
|
||
| (params, pk, k) | ||
| } | ||
| } | ||
|
|
||
| impl WasmCircuit for Circuit<WithdrawProverKnowledge<F, RANGE_PROOF_CHUNK_SIZE>> { | ||
| fn load_files() -> (Params, ProvingKey, u32) { | ||
| let params = unmarshall_params(include_bytes!("../../artifacts/withdraw/params.bin")) | ||
| .expect("Failed to unmarshall params"); | ||
| let (k, pk) = unmarshall_pk::< | ||
| <WithdrawProverKnowledge<F, RANGE_PROOF_CHUNK_SIZE> as ProverKnowledge<F>>::Circuit, | ||
| >(include_bytes!("../../artifacts/withdraw/pk.bin")) | ||
| .expect("Failed to unmarshall pk"); | ||
|
|
||
| (params, pk, k) | ||
| } | ||
| } |
There was a problem hiding this comment.
I strongly suggest unifying these functions with a single helper
There was a problem hiding this comment.
added macro for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the code refactor of
shielder-wasmbindings into newshielder_bindingscrate. Particularly:/circuitsmodule with better error handlingsecrets.rsmoduleIn next PR, going to delete
shielder-wasmcrate, changeshielder-sdk-crypto-wasmto useshielder_bindingsand change CI to compile it.