small challenge deletion fix

app/challenges-platform/services/submissions-service.ts

@@ -109,6 +109,8 @@ const beforeCreate = async (
   const challengeResult = await ChallengesService.findByUuid(challengeId);
   if (!challengeResult.ok) {
     return Err(new Error("Failed to find challenge"));
+  } else if (challengeResult.val.deleted === true) {
+    return Err(new Error("Challenge is deleted"));
   }
 
   const participantResult = await ParticipantsService.findByUuid(participantId);

test/challenges-platform/services/submissions-service.test.ts

@@ -85,6 +85,27 @@ describe("SubmissionService", () => {
         expect(result.val.toString()).toBe("Error: Failed to find challenge");
       });
     });
+
+    describe("when challenge is deleted", () => {
+      it("returns an error", async () => {
+        const factory = await challengeFactory();
+        // Delete the challenge
+        const challenge = await ChallengesService.destroy(factory.uuid);
+        if (!challenge.ok)
+          fail("Expected challenge to be Ok, something went really wrong");
+
+        const participant = await participantFactory();
+
+        const result = await SubmissionService.create(
+          challenge.val.uuid,
+          participant.uuid,
+        );
+
+        expect(result.err).toBe(true);
+        expect(result.val.toString()).toBe("Error: Challenge is deleted");
+      });
+    });
+
     describe("when participant does not exist", () => {
       it("returns an error", async () => {
         const challenge = await challengeFactory();