Add ekubo pools #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR adds Arbitrary Proposal for adding ekubo pools (not options too!!). Please check it, as well as the fork test. In |
|
Also commented out |
DaveVodrazka
approved these changes
Oct 21, 2024
tensojka
approved these changes
Oct 23, 2024
Comment on lines
+76
to
+85
| loop { | ||
| match voter_addresses.pop_front() { | ||
| Option::Some(address) => { | ||
| let current_voter: ContractAddress = (*address).try_into().unwrap(); | ||
| prank(CheatTarget::One(gov_addr), current_voter, CheatSpan::TargetCalls(1)); | ||
| props.vote(prop_id, 1); | ||
| }, | ||
| Option::None(()) => { break (); } | ||
| } | ||
| }; |
There was a problem hiding this comment.
did you know the famed for loop has come to our land?
https://community.starknet.io/t/cairo-v2-7-0-is-coming/114362
(not worth changing, just wanted to mention)
|
|
||
| // Add the lptokens to the AMM | ||
| let call_voladjspd = FixedTrait::new_unscaled(10_000, false); | ||
| let put_voladjspd = FixedTrait::new_unscaled(50_000, false); |
There was a problem hiding this comment.
I think this is too high, DMd
tensojka
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.