feat: return options as a struct #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekHauzr
reviewed
Jan 26, 2023
| @@ -93,7 +94,7 @@ func save_all_non_expired_options_with_premia_to_array{syscall_ptr: felt*, peder | |||
|
|
|||
| return save_all_non_expired_options_with_premia_to_array( | |||
| lptoken_address, | |||
| array_len_so_far + OptionWithPremia.SIZE, | |||
| array_len_so_far + 1, | |||
There was a problem hiding this comment.
now the array length is not x*7, but x because of element in the array being OptionWithPremia
MarekHauzr
force-pushed
the
dev
branch
2 times, most recently
from
4401ff0 to
65e3cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.