[ENG-5352] Messaging for account status changes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
sub-pub
branch
2 times, most recently
from
ed4293d to
a6a0dbb
Compare
Johnetordoff
changed the title
Johnetordoff
commented
Feb 29, 2024
| @@ -0,0 +1,8 @@ | |||
| from django.core.management.base import BaseCommand | |||
There was a problem hiding this comment.
just for dev ease of use
Johnetordoff
force-pushed
the
sub-pub
branch
from
a6a0dbb to
a6630e3
Compare
Johnetordoff
commented
Feb 29, 2024
| def ready(self): | ||
| thread = threading.Thread(target=listen_for_osf_signals) | ||
| thread.daemon = True | ||
| thread.start() |
There was a problem hiding this comment.
There's many ways we could go to set up an non-blocking task here. This was easiest because it was difficult to make this a task in celery because our GV side celery app isn't setup. Other methods, such as asyncio were investigated, but this was the shortest.
Johnetordoff
changed the title
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR for demos of sub-pub system
Currently a simple listener function in an easy to set up management command. Prints out simple message in addon_service logs.
OSF side:
CenterForOpenScience/osf.io#10550
Ticket:
https://openscience.atlassian.net/browse/ENG-5352